-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guides: Update bincompat #367
guides: Update bincompat #367
Conversation
39ea7ce
to
95be007
Compare
7707676
to
1c7c5ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-by: Daniel Paun [email protected]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content looks good, but there are some rendering issues, see the comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Reviewed-by: Mihnea Firoiu [email protected]
1c7c5ed
to
663dbbd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now, thanks.
Reviewed-by: Stefan Jumarea [email protected]
Update binary compatibility guide to focus on application `catalog`, KraftKit-based runs, the `base` kernel image and the application registry. Signed-off-by: Razvan Deaconescu <[email protected]>
Split current guide on binary-compatibility. Move general introduction to concepts section and reference the other sections. Signed-off-by: Razvan Deaconescu <[email protected]>
Add guide center of users of the application catalog. Detail how to use prebuilt applications in the registry and how to build and run applications in the catalog repository. Signed-off-by: Razvan Deaconescu <[email protected]>
Detail the internals of the build and run phases when using the catalog. Present backing QEMU commands used for running. Signed-off-by: Razvan Deaconescu <[email protected]>
Add guide on using Firecracker for catalog applications. Signed-off-by: Razvan Deaconescu <[email protected]>
Add developer-centric guide to add new applications and examples to the catalog. List steps to prepare recipe files (`Dockerfile`, `Kraftfile`), documentation files and support files. Signed-off-by: Razvan Deaconescu <[email protected]>
Reference bincompat guides in the bincompat concepts page. Signed-off-by: Razvan Deaconescu <[email protected]>
0355a4c
to
5cf732b
Compare
This commit refactors the recent guide entries on the Unikraft Community Catalog of pre-built unikernel applications. Specifically this change: - Increases the slug length of guides, making URL sharing more friendly; - Migrates the guide on contributing to the application catalog into the "Contributing" section of the website; - Merges the pages of `bincompat.mdx` and `compatibility.mdx` since they represent the same information; - Adjusts the MDX formatting of all code snippets for better readability. Signed-off-by: Alexander Jung <[email protected]>
Signed-off-by: Alexander Jung <[email protected]>
5cf732b
to
cbce3b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @razvand, this is very well written and put together, gg!
Reviewed-by: Alexander Jung [email protected]
Approved-by: Alexander Jung [email protected]
Update binary compatibility guide to focus on application
catalog
, KraftKit-based runs, thebase
kernel image and the application registry.